[Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

[Petr Spacek]

On 27.1.2015 18:02, Alexander Bokovoy wrote:
>>
>> -    slapi_search_internal_get_entry(sdn, attrs, &entry,
>> -                                    otp_config_plugin_id(otp_config));
>> +    search_result = slapi_search_internal_get_entry(sdn, attrs, &entry,
>> +            otp_config_plugin_id(otp_config));
>> +    if (search_result != LDAP_SUCCESS) {
>> +        LOG_TRACE("Entry not found. Error code: %d\n", search_result);
>> +    }
> I would rather say something more defensive here:
> "Unable to access LDAP entry. Perhaps it does not exist? Error code: %d\n"

Would it be possible to print the DN? It may be useful in cases where it
actually happened ...

-- 
Petr^2 Spacek