[Freeipa-devel] [PATCH 0004] added dbus-python dependency to freeipa-client

[Martin Kosek]

On 01/28/2015 10:11 AM, Martin Babinsky wrote:
> On 01/28/2015 09:46 AM, Martin Kosek wrote:
>> On 01/27/2015 06:45 PM, Martin Babinsky wrote:
>>> On 01/27/2015 10:41 AM, Martin Basti wrote:
>>>> On 26/01/15 17:36, Martin Babinsky wrote:
>>>>> See attached patch related to
>>>>> https://fedorahosted.org/freeipa/ticket/4863.
>>>>>
>>>>> Martin^3
>>>>>
>>>>>
>>>>
>>>> Thank for your patch,
>>>>
>>>> IMO client is not dependent on dbus module, but ipapython requires dbus
>>>> module.
>>>> We should add this dependency to ipapython package, because AFAIK
>>>> ipa-client-install do not need dbus at all.
>>>>
>>>> Martin^2
>>>>
>>>>
>>> True indeed. I have moved 'dbus-python' dependency to freeipa-python and
>>> removed it from freeipa-server.
>>>
>>> Now freeipa-python package should cover dbus-python deps for the whole
>>> freeipa-* suite.
>>>
>>> Martin^3
>>
>> I do not think it should be removed from freeipa-server. After all, it is
>> direct dependency of this package:
>>
>> $ git grep "import dbus"
>> ipapython/certmonger.py:import dbus
>> ipaserver/install/cainstance.py:import dbus
>> ipaserver/install/httpinstance.py:import dbus
>>
>> It will not change the outcome, as freeipa-python is a dependency of
>> freeipa-server, but will be better for packaging hygiene, IMO.
>>
>> Martin
>>
> 
> Ok updated the patch accordingly.
> 

This is fine, ACK.

Pushed to:
master: debb9974988b4a89d0aab8ea8c3b3a1a54397d1f
ipa-4-1: f5352a8f2f777dce3bf91ac63e04e75532053762

Martin