[Freeipa-devel] [PATCH 0262] Installer FIX: remove temporal ccache

[Jan Cholasta]

Dne 2.6.2015 v 10:53 Martin Basti napsal(a):
> On 02/06/15 10:24, Fraser Tweedale wrote:
>> On Mon, Jun 01, 2015 at 04:47:46PM +0200, Martin Basti wrote:
>>> On 01/06/15 16:14, Rob Crittenden wrote:
>>>> Martin Basti wrote:
>>>>> Fixes an issue caused by the latest installer patches pushed to
>>>>> master.
>>>>>
>>>>> Patch attached.
>>>>>
>>>>>
>>>>>
>>>> The use of globals makes my skin crawl a bit, but since you're making
>>>> changes in here you should take a look at this ticket:
>>>> https://fedorahosted.org/freeipa/ticket/5042
>>>>
>>>> rob
>>> Hi Rob,
>>>
>>> this is fix for that ticket, I missed the ticket somehow.
>>>
>>> Thanks.
>>> Martin^2
>>>
>>> --
>>> Manage your subscription for the Freeipa-devel mailing list:
>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>> Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
>> Fixes the problem for me, but I agree with Rob re globals - a
>> context manager would be much nicer.  Something like (pseudocode):
>>
>>      @contextlib.context_manager
>>      def private_ccache():
>>          ... stuff currently in init_private_ccache()
>>          yield
>>          ... stuff currently in destroy_private_ccache()
>>
>> Then in ipa-server-install main():
>>
>>      with private_ccache:
>>         if not options.uninstall:
>>             server.install_check(options)
>>             server.install(options)
>>          else:
>>             server.uninstall_check(options)
>>             server.uninstall(options)
>>
>> Cheers,
>> Fraser
> Thank you!
>
> However, I would wait for Honza's answer, if this will fit in his big
> installer plan.
>

The code will be gradually ported to the new install framework, removing 
the globals in the process.

The context manager was used before the code was moved into a module and 
was removed on purpose to allow the split to two functions, which is 
necessary for the port.

ACK on the patch.

Pushed to master: af8f44c86ab37d83b952c0f021c6509c48be7da8

-- 
Jan Cholasta