[Freeipa-devel] [PATCH 0262] Installer FIX: remove temporal ccache

[Martin Basti]

On 02/06/15 16:00, Jan Cholasta wrote:
> Dne 2.6.2015 v 15:57 Martin Basti napsal(a):
>> On 02/06/15 10:24, Fraser Tweedale wrote:
>>> On Mon, Jun 01, 2015 at 04:47:46PM +0200, Martin Basti wrote:
>>>> On 01/06/15 16:14, Rob Crittenden wrote:
>>>>> Martin Basti wrote:
>>>>>> Fixes an issue caused by the latest installer patches pushed to
>>>>>> master.
>>>>>>
>>>>>> Patch attached.
>>>>>>
>>>>>>
>>>>>>
>>>>> The use of globals makes my skin crawl a bit, but since you're making
>>>>> changes in here you should take a look at this ticket:
>>>>> https://fedorahosted.org/freeipa/ticket/5042
>>>>>
>>>>> rob
>>>> Hi Rob,
>>>>
>>>> this is fix for that ticket, I missed the ticket somehow.
>>>>
>>>> Thanks.
>>>> Martin^2
>>>>
>>>> -- 
>>>> Manage your subscription for the Freeipa-devel mailing list:
>>>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>>>> Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
>>> Fixes the problem for me, but I agree with Rob re globals - a
>>> context manager would be much nicer.  Something like (pseudocode):
>>>
>>>      @contextlib.context_manager
>>>      def private_ccache():
>>>          ... stuff currently in init_private_ccache()
>>>          yield
>>>          ... stuff currently in destroy_private_ccache()
>>>
>>> Then in ipa-server-install main():
>>>
>>>      with private_ccache:
>>>         if not options.uninstall:
>>>             server.install_check(options)
>>>             server.install(options)
>>>          else:
>>>             server.uninstall_check(options)
>>>             server.uninstall(options)
>>>
>>> Cheers,
>>> Fraser
>> Hello,
>>
>> comments below:
>>
>> 1)
>> +    Str(
>> +        'memberprincipal',
>> +        label=_('Failed principals'),
>> +    ),
>> +    Str(
>> +        'ipaallowedtarget',
>> +        label=_('Failed targets'),
>> +    ),
>> +    Str(
>> +        'servicedelegationrule',
>> +        label=_('principal member'),
>> +    ),
>> Are these names correct?
>> # ipa servicedelegationrule-find
>> ----------------------------------
>> 1 service delegation rule matched
>> ----------------------------------
>>    Delegation name: ipa-http-delegation
>>    Allowed Target: ipa-ldap-delegation-targets, 
>> ipa-cifs-delegation-targets
>>    Failed principals: HTTP/vm-093.example.com at EXAMPLE.COM
>>
>>
>> 2)
>> + pattern='^[a-zA-Z0-9_.][a-zA-Z0-9_.-]{0,252}[a-zA-Z0-9_.$-]?$',
>> +            pattern_errmsg='may only include letters, numbers, _, -, 
>> ., '
>> +                           'and a space inside',
>>
>> This regex does not allow space inside
>> In [6]: print re.match(pattern, 'lalalala lalala')
>> None
>>
>>
>> 3)
>> +            yield Str('%s*' % name, cli_name='%ss' % name, doc=doc,
>> +                      label=_('member %s') % name,
>> +                      csv=True, alwaysask=True)
>>
>> IMHO CSV values should not be supported.
>> Honza told me, the option doesn't work anyway.
>>
>> Patch with minor fixes attached.
>>
>> I removed unused code and PEP8 complains
>
> Wrong thread :-)
>
Sorry :-)

-- 
Martin Basti