[Freeipa-devel] [PATCH] Use Exception class instead of BaseException

[Martin Basti]

On 01/06/15 06:33, Niranjan wrote:
> Greetings,
>
> I would like to present patch for replacing StandardError exception
> with Exception class in ipapython/adminutil.py. Also replacing
> BaseException class with Exception class.
>
> Though the use of StandardError is many places. I would like to start
> with ipapython/adminutil.py
>
> This is my first patch. Please let me know if my approach on this is
> correct.
>
> Regards
> Niranjan
>
>
Thank you,

I have another objection:

1)
Please do not copy/paste code, use this for except

except (Exception, SystemExit) as exception:


Martin Basti
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150603/fdcc778c/attachment.htm>