[Freeipa-devel] [PATCH 0050] Allow to skip lint when building FreeIPA.

[Lukas Slebodnik]

On (04/06/15 12:20), David Kupka wrote:
>
>-- 
>David Kupka

>From f68607e9a3db4cd8893c465d804615aac34afc29 Mon Sep 17 00:00:00 2001
>From: David Kupka <dkupka at redhat.com>
>Date: Thu, 4 Jun 2015 12:10:37 +0200
>Subject: [PATCH] Allow to skip lint when building FreeIPA.
>
>Target 'lint' does nothing when SKIP_LINT is set to anything else than "no".
>By default the variable is unset and lint is executed as always was.
>---
> Makefile | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
>diff --git a/Makefile b/Makefile
>index abf58382960099a54b8920dd0e741b9fda17682f..4ad1d69dfc330c3a48a13a0b525e1f533183236d 100644
>--- a/Makefile
>+++ b/Makefile
>@@ -53,6 +53,8 @@ ifneq ($(DEVELOPER_MODE),0)
> LINT_OPTIONS=--no-fail
> endif
> 
>+SKIP_LINT ?= no
>+
> PYTHON ?= $(shell rpm -E %__python || echo /usr/bin/python2)
> 
> CFLAGS := -g -O2 -Wall -Wextra -Wformat-security -Wno-unused-parameter -Wno-sign-compare -Wno-missing-field-initializers $(CFLAGS)
>@@ -116,9 +118,10 @@ client-dirs:
> 	fi
> 
> lint: bootstrap-autogen
>-	./make-lint $(LINT_OPTIONS)
>-	$(MAKE) -C install/po validate-src-strings
>-
>+	if [ "$(SKIP_LINT)" == "no" ]; then \
                        ^^
                     It's better to use just one character.
man test says:
       STRING1 = STRING2
              the strings are equal

       STRING1 != STRING2
              the strings are not equal

LS