[Freeipa-devel] [PATCH 0011] check-for-existing-and-self-referential-segments

[Ludwig Krispenz]

On 06/08/2015 04:47 PM, Petr Vobornik wrote:
> On 06/03/2015 06:20 PM, Simo Sorce wrote:
>> On Wed, 2015-06-03 at 14:53 +0200, Ludwig Krispenz wrote:
>>> Hi,
>>>
>>> this should prevent adding duplicate segments or segments with same
>>> start and end node
>>
>> LGTM!
>>
>> Simo.
>>
>
> The self referential check is done only in ipa_topo_pre_add. But it is 
> still possible to create self referential in mod.
>
> Interesting thing is if I:
> - have segment (A, B)
> - modify it to (A, A) (success)
> - add (A, B), got: "Server is unwilling to perform: Segment already 
> exists in topology or is self referential. Add rejected."
> - removal of (A, A): "Server is unwilling to perform: Removal of 
> Segment disconnects topology.Deletion not allowed." note that, there 
> are also: (A, D) and (A, C) segments.
>
> ACK if it will be addressed in separate patch.
yes, it will be. You find interesting scenarios :-)