[Freeipa-devel] [PATCH 0384-0385] Replace isc_atomic_* in with reference counter

Tomas Hozza thozza at redhat.com
Tue Jun 23 12:18:34 UTC 2015


On 23.06.2015 11:32, Petr Spacek wrote:
> On 10.6.2015 19:07, Petr Spacek wrote:
> > Hello,
> >
> > Replace isc_atomic_* in MetaLDAP with reference counter abstraction.
> > +
> > Replace isc_atomic_* in instance tainting with reference counter abstraction.
> >
> > Reference counters are used as abstraction which hides missing isc_atomic_*()
> > functions on some architectures.
> >
> >
> > This change is necessary for architectures like s390x and ppc64le where BIND
> > does not provide isc_atomic_* abstractions.
>
> Fixed version of the patch is attached.
>
> The same code is also on Github:
> https://github.com/pspacek/bind-dyndb-ldap/commits/atomic_to_refcnt
>
> Thank you for review!
>
I did formal review of patches 384 and 385. The fixed version looks good.

ACK.

Regards,
-- 
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience

PGP: 1D9F3C2D
Red Hat Inc. http://cz.redhat.com




More information about the Freeipa-devel mailing list