[Freeipa-devel] [PATCHES 399-401] Allow multiple API instances

[Tomas Babej]

On 03/04/2015 11:55 AM, Martin Kosek wrote:
> On 03/04/2015 11:13 AM, Jan Cholasta wrote:
>> Dne 3.3.2015 v 16:11 Martin Kosek napsal(a):
>>> On 03/03/2015 04:09 PM, Jan Cholasta wrote:
>>>> Dne 3.3.2015 v 16:04 Tomas Babej napsal(a):
>>>>> On 03/03/2015 04:01 PM, Martin Kosek wrote:
>>>>>> On 03/03/2015 03:49 PM, Jan Cholasta wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> the attached patches provide an attempt to fix
>>>>>>> <https://fedorahosted.org/freeipa/ticket/3090>.
>>>>>>>
>>>>>>> Patch 401 serves as an example and modifies ipa-advise to use its own
>>>>>>> API
>>>>>>> instance for Advice plugins.
>>>>>>>
>>>>>>> Honza
>>>>>> Thanks. At least patches 399 and 400 look reasonable short for 4.2.
>>>>>>
>>>>>> So with these patches, could we also get rid of
>>>>>> temporary_ldap2_connection we
>>>>>> have in ipa-replica-install? Petr3 may have other examples he met in
>>>>>> the past...
>>>> I think we can. Shall I prepare a patch?
>>> If it is reasonable simple, I would go for it. It would be another selling
>>> point for your patches.
>> Done.
>>
> Thanks, this looks great! It proves the point with the separate API object.
> LGTM, I will let Tomas to continue with standard review then.
>
> Martin

Codewise looks good to me.

I tested the server and replica installation, which went well. And of 
course, our ipa-advise tests detected no breakage, hence it's a ACK.

Pushed to master: 8713c5a6953e92f72d9ea7aad40588c284011025

Tomas