[Freeipa-devel] [PATCH 0209] Fix logically dead code in ipap11helper module

[Petr Spacek]

On 9.3.2015 13:52, Martin Basti wrote:
> Patch attached.

ACK for this patch.

When you are at it, it would be good to fix other warnings too. GCC on Fedora
21 is yelling at me:

p11helper.c: In function ‘P11_Helper_find_keys’:
p11helper.c:1062:23: warning: comparison between signed and unsigned integer
expressions [-Wsign-compare]
     for (int i = 0; i < objects_len; ++i) {
                       ^
p11helper.c: At top level:
p11helper.c:2125:1: warning: missing initializer for field ‘tp_free’ of
‘PyTypeObject’ [-Wmissing-field-initializers]
 };
 ^
In file included from /usr/include/python2.7/Python.h:80:0,
                 from p11helper.c:37:
/usr/include/python2.7/object.h:391:14: note: ‘tp_free’ declared here
     freefunc tp_free; /* Low-level free-memory routine */

Feel free to fix it in a separate patch.

-- 
Petr^2 Spacek