[Freeipa-devel] [PATCHES 306-316] Automated migration tool from Winsync

[Jan Cholasta]

Hi,

Dne 10.3.2015 v 16:35 Tomas Babej napsal(a):
>
> On 03/09/2015 12:26 PM, Tomas Babej wrote:
>> Hi,
>>
>> this couple of patches provides a initial implementation of the
>> winsync migration tool:
>>
>> https://fedorahosted.org/freeipa/ticket/4524
>>
>> Some parts could use some polishing, but this is a sound foundation.
>>
>> Tomas
>>
>>
>>
>
> Attaching one more patch to the bundle. This one should make the winsync
> tool readily available after install.
>
> Tomas
>
>

Nitpicks:

The winsync_migrate module should be in ipaserver.install. Also I don't 
see why it has to be a package when there is just one short file in it.

By convention, the AdminTool subclass should be named WinsyncMigrate, or 
the tool should be named ipa-migrate-winsync.

Honza

-- 
Jan Cholasta