[Freeipa-devel] [PATCH 140] extdom: migrate check-based test to cmocka

Jakub Hrozek jhrozek at redhat.com
Fri Mar 13 14:14:55 UTC 2015


On Fri, Mar 13, 2015 at 11:56:46AM +0100, Sumit Bose wrote:
> On Wed, Mar 04, 2015 at 06:42:05PM +0100, Sumit Bose wrote:
> > Hi,
> > 
> > this is the first patch for https://fedorahosted.org/freeipa/ticket/4922
> > which converts the check-based tests of the extdom plugin to cmocka.
> > 
> > bye,
> > Sumit
> 
> Rebased version attached.
> 
> bye,
> Sumit

The test itself is fine, but did freeipa consider moving to cmocka-1.0+
to avoid warnings like:
ipa_extdom_cmocka_tests.c: In function ‘main’:
ipa_extdom_cmocka_tests.c:408:5: warning: ‘_run_tests’ is deprecated
(declared at /usr/include/cmocka.h:2001) [-Wdeprecated-declarations]
     return run_tests(tests);

But I'm fine with ACKing this patch, the conversion should be done
separately.




More information about the Freeipa-devel mailing list