[Freeipa-devel] [PATCHES 137-139] extdom: add err_msg member to request context

[Jakub Hrozek]

On Fri, Mar 13, 2015 at 11:55:09AM +0100, Sumit Bose wrote:
> On Wed, Mar 04, 2015 at 06:35:22PM +0100, Sumit Bose wrote:
> > Hi,
> > 
> > this patch series improves error reporting of the extdom plugin
> > especially on the client side. Currently there is only SSSD ticket
> > https://fedorahosted.org/sssd/ticket/2463 . Shall I create a
> > corresponding FreeIPA ticket as well?
> > 
> > In the third patch I already added a handful of new error messages.
> > Suggestions for more messages are welcome.
> > 
> > bye,
> > Sumit
> 
> Rebased versions attached.
> 
> bye,
> Sumit

The patches look good and work fine. I admit I cheated a bit and
modified the code to return a failure. Then I saw on the client:

[sssd[be[ipa.example.com]]] [ipa_s2n_exop_send] (0x0400): Executing extended operation
[sssd[be[ipa.example.com]]] [ipa_s2n_exop_done] (0x0040): ldap_extended_operation result: Operations
error(1), Failed to create fully qualified name.
[sssd[be[ipa.example.com]]] [ipa_s2n_exop_done] (0x0040): ldap_extended_operation failed, server logs might contain more details.
[sssd[be[ipa.example.com]]] [ipa_s2n_get_user_done] (0x0040): s2n exop request failed.

I just saw one typo:

> @@ -918,6 +934,7 @@ static int handle_sid_request(struct ipa_extdom_ctx *ctx,
>              ret = sss_nss_getorigbyname(pwd.pw_name, &kv_list, &id_type);
>              if (ret != 0 || !(id_type == SSS_ID_TYPE_UID
>                                  || id_type == SSS_ID_TYPE_BOTH)) {
> +                set_err_msg(req, "Failed ot read original data");
                                     ~~~~~~~~~
>                  if (ret == ENOENT) {
>                      ret = LDAP_NO_SUCH_OBJECT;
>                  } else {

And a compilation warning caused by previous patches.

So ACK provided the typo is fixed prior to pushing the patch.