[Freeipa-devel] [PATCHES 0204-0207, 0211] Server upgrade: Make LDAP data upgrade deterministic

David Kupka dkupka at redhat.com
Thu Mar 19 11:20:32 UTC 2015


On 03/13/2015 03:08 PM, Martin Basti wrote:
> On 12/03/15 16:21, Rob Crittenden wrote:
>> Martin Basti wrote:
>>> The patchset ensure, the upgrade order will respect ordering of entries
>>> in *.update files.
>>>
>>> Required for: https://fedorahosted.org/freeipa/ticket/4904
>>>
>>> Patch 205 also fixes https://fedorahosted.org/freeipa/ticket/3560
>>>
>>> Required patch mbasti-0203
>>>
>>> Patches attached.
>>>
>>>
>>>
>> Just reading the patches, untested.
>>
>> I think ordered should default to True in the update() method of
>> ldapupdater to keep in spirit with the design.
>>
>> Otherwise LGTM that it implements what was designed.
>>
>> rob
>>
>>
> New patch that switch default value for ordered to True attached.
>
>
>
Looks and works as expected, ACK.

-- 
David Kupka




More information about the Freeipa-devel mailing list