[Freeipa-devel] [PATCH 0023] enable debugging of spawned ntpd command during client install

[Jan Cholasta]

Hi,

Dne 25.3.2015 v 15:26 Martin Babinsky napsal(a):
> The attached patch related to https://fedorahosted.org/freeipa/ticket/4931

Please make sure <https://fedorahosted.org/freeipa/ticket/3048> stays fixed.

>
> It is certainly not a final solution, more of an initial "hack" of sorts
> just to gather some suggestions, since I am not even sure if this is the
> right thing to do.
>
> The reporter from bugzilla suggests to enable debugging of ALL commands
> called through ipautil.run(), but I think that fixing all cca 157 found
> usages of run() is too much work with a quite small benefit.
>
> Anyway I would welcome some opinions about this: should the external
> commands really inherit the debug settings of ipa-* utilities, and if
> so, is the method showed in this patch the right way to do it?

I am not a fan of this method, ipautil.run does not know anything about 
the command it runs and I think it should stay that way.

I would prefer to have an ipautil.run wrapper with debug flag using 
appropriate debugging option for each command where we need to 
conditionally enable debugging. Or just add the debugging option 
unconditionally to every command where it could be useful.

Honza

-- 
Jan Cholasta