[Freeipa-devel] [PATCH 0047] Unsaved changes dialog inconsistent

[Petr Vobornik]

On 04/30/2015 07:43 PM, Gabe Alford wrote:
> Thanks Kyle and Petr.
>
> Update patch attached.

Renaming the buttons also requires to update webui integration tests in 
ipatests/test_webui, quick search:
   ipatests/test_webui/test_realmdomains.py:42,48
   ipatests/test_webui/ui_driver.py:1221,1246,1464,1483


>
> On Wed, Apr 29, 2015 at 7:59 AM, Kyle Baker <kybaker at redhat.com> wrote:
>
>>
>> ----- Original Message -----
>>> On 04/27/2015 03:03 PM, Gabe Alford wrote:
>>>> Hello,
>>>>
>>>> Fix for https://fedorahosted.org/freeipa/ticket/4926
>>>>
>>>> Thanks,
>>>>
>>>> Gabe
>>>>
>>>
>>> PatternFly has new recommendations for terminology and wording [1]. I'm
>>> not entirely sure if the usage of 'save' here is good. PF defines 'edit'
>>> as the recommended term. The page doesn't say if 'save' is not
>>> recommended, though. Save seems to me as a confirmation of editing.
>>
>> Yes I think save would be best here based on the message given.
>>
>> Thanks for checking out the Terminology screen!
>>
>>>
>>> Kyle, could you advise what is the best term for reflecting user changes
>>> and for confirmation of this action?
>>>
>>> Technical notes:
>>> 1. it would be better to add a new string and then use it in the button
>>> instead of having 'Save' text for '@i18n:buttons.update' definition.
>>>
>>> 2. String changes in internal.py should be also reflected in
>>> install/ui/test/data/ipa_init.json (for static web ui demo).
>>>
>>> 3. optional: in addition to text change, buttons and related actions
>>> could also be renamed (same reasons as in 1). It's more proper but much
>>> more complicated.
>>>
>>>
>>> [1]
>> https://www.patternfly.org/styles/terminology-and-wording/#action-labels
>>> --
>>> Petr Vobornik
>>>
>>
>


-- 
Petr Vobornik