[Freeipa-devel] [PATCHES 0233-0234] DNSSEC: forwarders validation

[David Kupka]

On 05/06/2015 03:20 PM, Martin Basti wrote:
> On 05/05/15 15:00, Martin Basti wrote:
>> On 30/04/15 15:37, David Kupka wrote:
>>> On 04/24/2015 02:56 PM, Martin Basti wrote:
>>>> Patches attached.
>>>>
>>>>
>>>>
>>>>
>>> Hi,
>>> thanks for patches.
>>>
>>> 1. You changed message in DNSServerNotRespondingWarning class but not
>>> the test in ipatest/test_xmlrpc/test_dns_plugin.py
>>>
>>> nitpick. Please spell 'edns' correctly. I've seen several instances
>>> of 'ends'.
>>>
>> Thank you,
>>
>> updated patches attached:
>> * new error messages
>> * logging to debug log server output if exception was raised
>> * fixed test
>> * fixed spelling
>>
>>
>>
> Fixed tests (again)
>
> Updated patches attached
>
The code looks good to me and tests are no longer broken. (I would 
prefer better fix of the tests but given that the priorities are 
different now it can wait.)

Petr, can you please confirm that the patch set works for you?

-- 
David Kupka