[Freeipa-devel] [PATCHES 0231-0232] Server Upgrade: support base64 encoded values in update files + remove CSV

[Jan Cholasta]

Dne 7.5.2015 v 19:54 Martin Basti napsal(a):
> On 07/05/15 11:09, Martin Basti wrote:
>> On 06/05/15 13:17, Martin Basti wrote:
>>> On 29/04/15 10:07, Jan Cholasta wrote:
>>>> Dne 27.4.2015 v 16:46 Martin Basti napsal(a):
>>>>> On 27/04/15 13:05, Martin Basti wrote:
>>>>>> On 23/04/15 13:06, Martin Basti wrote:
>>>>>>> On 16/04/15 17:14, Martin Basti wrote:
>>>>>>>> https://fedorahosted.org/freeipa/ticket/4984
>>>>>>>>
>>>>>>>> I had to remove CSV (which is evil) to be able fix this ticket.
>>>>>>>>
>>>>>>>> Patches attached.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> Updated patches attached.
>>>>>>>
>>>>>>> --
>>>>>>> Martin Basti
>>>>>>>
>>>>>>>
>>>>>> Rebased patches attached.
>>>>>>
>>>>>> --
>>>>>> Martin Basti
>>>>>>
>>>>>>
>>>>> rebased patches attached
>>>>>
>>>>> --
>>>>> Martin Basti
>>>>>
>>>>>
>>>>>
>>>>
>>>> ACK on patch 231.
>>>>
>>>> BTW I have found a 7 year old bug caused by CSV while reviewing it:
>>>> <https://fedorahosted.org/freeipa/ticket/5007>.
>>>>
>>>> There is also similar git-only bug in
>>>> install/updates/10-uniqueness.update:
>>>>
>>>>     default:uniqueness-subtrees: 'cn=accounts,$SUFFIX'
>>>>     default:uniqueness-subtrees: 'cn=deleted
>>>> users,cn=accounts,cn=provisioning,$SUFFIX'
>>>>
>>>> but your patch fixes it.
>>>>
>>>> I will review patch 232 later.
>>>>
>>>> Honza
>>>>
>>> Honza doesn't like original 232 so much.
>>>
>>> Updated patch 232 attached
>>>
>>>
>>>
>> Updated patch 232 attached
>>
>> --
>> Martin Basti
>>
>>
> Updated patches attached.
>
> --
> Martin Basti
>

ACK.

Pushed to master: 520bbd001b68bc51a79c2b4a9684fb1c12a582cd

-- 
Jan Cholasta