[Freeipa-devel] [PATCH 0322-0337] Fix mysterious failures in PTR record synchronization

[Tomas Hozza]

On 05/05/2015 05:24 PM, Petr Spacek wrote:
> Hello,
> 
> Attached patch set is the best fix for
> https://fedorahosted.org/bind-dyndb-ldap/ticket/155
> I was able to write.
> 
> This patch set should fix vast majority of race conditions. Unfortunately it
> cannot be 100 % reliable without support for LDAP transactions.
> 
> For convenience you can download the whole tree from
> https://github.com/pspacek/bind-dyndb-ldap/commits/t155.syncptr
> HEAD = da2552632f6ce67f1bb9d9b3cdd3e0a8e06ce9ea
> 
> Enjoy.
> 

Hi.

There is one unused variable after patch 325
Move SOA serial update functions to zone.c.

- it looks like you forgot to remove:
https://github.com/pspacek/bind-dyndb-ldap/blob/d616021d6665ebab97035efb687a88a4a139f636/src/ldap_helper.c#L3892
https://github.com/pspacek/bind-dyndb-ldap/blob/d616021d6665ebab97035efb687a88a4a139f636/src/ldap_helper.c#L4037
https://github.com/pspacek/bind-dyndb-ldap/blob/d616021d6665ebab97035efb687a88a4a139f636/src/ldap_helper.c#L4038

Other than that, patches look good. I tested them and reviewed from
https://github.com/pspacek/bind-dyndb-ldap/commits/t155.syncptr

ACK with the fix for unused variable.

Regards,
-- 
Tomas Hozza
Software Engineer - EMEA ENG Developer Experience

PGP: 1D9F3C2D
Red Hat Inc.                               http://cz.redhat.com