[Freeipa-devel] [PATCH] manage replication topology in the shared tree

[Petr Vobornik]

On 05/21/2015 12:55 PM, thierry bordaz wrote:
> On 05/20/2015 05:40 PM, Ludwig Krispenz wrote:
>> please find new versions of patches 0003 and 0005 for  the topology
>> plugin.
>>
>> the ds plugin patch includes
>> - changes to match domain level patch
>> - remove trailing white spaces
>> - use proper oids for topology schema
>>
>> the install patch
>> - has the  70topology.ldif removed
>
> Hello Ludwig,
>
> I failed to do 'git am patch-0003', it returned a strange "Patch format
> detection failed.".
> However I was able to do 'git apply' and to review it.
>
> I focus on the points discussed during previous reviews.
> The patch is looking good to me. ACK

Patch 0005 looks good to me if we squash there attached patch(typo fixes).

I think that both 0003 and 0005 could be pushed. But I'll do it when 
testing with Domain Level patch is successful.

patch 0006 will be replaced with the one I'm working on.

>
> thanks
> thierry
>>
-- 
Petr Vobornik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wip-freeipa-pvoborni-0744-topology-installation-minor-fixes.patch
Type: text/x-patch
Size: 2268 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150522/9d71edc7/attachment.bin>