[Freeipa-devel] [PATCHES 145-148] ipa-kdb: add unit-test for filter_logon_info()

[Martin Kosek]

On 05/26/2015 01:33 PM, Sumit Bose wrote:
> Hi,
>
> these patches add some unit tests and some additional improvements
> related to the issues described in
> https://bugzilla.redhat.com/show_bug.cgi?id=1222475 . The original issue
> is fixed by a patch from Alexander attached to the ticket.
>
> The first patch converts the existing check-based test to cmocka. If I
> see it correctly all check-based test are converted now.

Cool! Before pushing, we should also reference ticket
https://fedorahosted.org/freeipa/ticket/4922
in the patch (no need to rebase right now).

>
> The second adds tests for filter_logon_info() where the original issue
> occurred. The wrong behavior in filter_logon_info() caused a crash in
> dom_sid_string() which is made a bit more robust together with
> string_to_sid() in the 3rd patch. The last patch add unit tests for
> those two calls as well.
>
> bye,
> Sumit
>
>