[Freeipa-devel] [PATCHES 377-379] Hardening of ipa-adtrust-install

[Martin Babinsky]

On 10/27/2015 04:24 PM, Tomas Babej wrote:
> Hi,
>
> this couple of patches harden the adtrust installer.
>
> Details in the commit messages.
>
> Fixes: https://fedorahosted.org/freeipa/ticket/5134
>
> Tomas
>
>
>
NACK,

in the first patch you forgot to instantiate the caught exception in the 
following snippet:

+        except Exception:
+            root_logger.debug("Exception occured during SID generation: 
{0}"
+                              .format(str(e)))

You should use 'except Exception as e:'.

I'm also not quite sure that it is enough to log the error at debug level.

If the sidgen task somehow fails, isn't it something which should 
interest the user and deserve at least warning-level message?

-- 
Martin^3 Babinsky