[Freeipa-devel] [PATCH] enable pem=True in export_pem_cert function

[Tomas Babej]

On 11/11/2015 02:03 AM, Niranjan wrote:
> Niranjan wrote:
>> Tomas Babej wrote:
>>> On 10/26/2015 08:59 PM, Niranjan wrote:
>>>> Greetings,
>>>>
>>>> export_pem_cert function from ipapython/certdb  should export the certificate
>>>> in pem format but instead exports the cert in der format as it doesn't enable pem=True.
>>>>
>>>> This patch specifies pem=True for export_pem_cert function
>>>>
>>>> Regards
>>>> Niranjan
>>>
>>> Hi,
>>>
>>> the patch looks good, however, I'm curious as to how did you find this
>>> bug? Does it affect anything?
>> I am part of the CS(dogtag) QE team, and as part of CS Automation, i am relying 
>> on some generic functions provided by ipapython. While using those functions
>> for our automation, I found it. 
>>>
>>> It seems to me that this part of the code is a dead branch which should
>>> be removed.
>> I did not look further ipapython, so i am not aware where else export_pem_cert
>> is being used, but i would like the functions in certdb.py be available.
>>>
>>> $ git grep export_pem_cert
>>> ipapython/certdb.py:    def export_pem_cert(self, nickname, location):
>>> ipaserver/install/certs.py:    def export_pem_cert(self, nickname,
>>> ipaserver/install/certs.py:        return self.nssdb.export_pem_ce..
> 
> Any update on this.
> 

Sure, I will push the patch. However, I am not sure how stable the
ipapython internal API is, so be watch out for changes if ipapython
package is upgraded.

ACK.

Pushed to master: 0152d16820e527060be3363f590c49544b51b710