[Freeipa-devel] [PATCH 0350] raise time limit for ldapsearch in upgrade

[Martin Basti]

On 18.11.2015 13:55, Martin Kosek wrote:
> On 11/18/2015 01:30 PM, Martin Basti wrote:
>> +    DEFAULT_TIME_LIMIT = -1.0
>> +    DEFAULT_SIZE_LIMIT = 0
> ...
>>           if time_limit is None or time_limit == 0:
>> -            time_limit = -1.0
>> +            if self.time_limit is not None and self.time_limit != 0:
>> +                time_limit = self.time_limit
>> +            else:
>> +                time_limit = self.DEFAULT_TIME_LIMIT
>> +
> I wonder why is the -1 default time limit a float number, I would expect that
> some trouble may emerge out of it. Maybe Rob knows?
>
Python LDAP allows to have smaller granularity than seconds and it 
internally convert time limit values to float.