[Freeipa-devel] [PATCH 0350] raise time limit for ldapsearch in upgrade

[Martin Basti]

On 18.11.2015 14:24, Martin Kosek wrote:
> On 11/18/2015 02:18 PM, Martin Basti wrote:
>>
>> On 18.11.2015 13:55, Martin Kosek wrote:
>>> On 11/18/2015 01:30 PM, Martin Basti wrote:
>>>> +    DEFAULT_TIME_LIMIT = -1.0
>>>> +    DEFAULT_SIZE_LIMIT = 0
>>> ...
>>>>            if time_limit is None or time_limit == 0:
>>>> -            time_limit = -1.0
>>>> +            if self.time_limit is not None and self.time_limit != 0:
>>>> +                time_limit = self.time_limit
>>>> +            else:
>>>> +                time_limit = self.DEFAULT_TIME_LIMIT
>>>> +
>>> I wonder why is the -1 default time limit a float number, I would expect that
>>> some trouble may emerge out of it. Maybe Rob knows?
>>>
>> Python LDAP allows to have smaller granularity than seconds and it internally
>> convert time limit values to float.
> Hm, ok. I was just curious since the value we expose in API is Int and the
> default does not use the smaller granularity, so I was thinking "Why bother?".
> If it is fixed in your patch, good. If not, good also, no need to bikeshed here
> I suppose.
I just keep the original values there, I do not want to touch it with 
this patch