[Freeipa-devel] [TESTS][PATCH 0006] Add comments to stageuser plugin tests

Martin Babinsky mbabinsk at redhat.com
Wed Nov 18 15:51:19 UTC 2015


On 11/18/2015 02:16 PM, Lenka Doudova wrote:
> Hi,
>
> here's a patch that adds a few comments to stageuser tests in order to
> allow easier determining of a problem when tests fail.
>
> Lenka
>
>

Hi Lenka,

Firstly a technical detail: Python indexes lists from 0, so the comments 
in 'options_ok' do not correctly map to the test names anyway.

I am also not sure if this patch is worth reviewing and pushing as it 
IMHO doesn't help in the identification of failed tests at all.

This should be solved at more fundamental level.

-- 
Martin^3 Babinsky




More information about the Freeipa-devel mailing list