[Freeipa-devel] [PATCH 0064] Check if IPA is configured before attempting a winsync migration

[Tomas Babej]

On 11/23/2015 12:11 PM, Martin Babinsky wrote:
> On 11/20/2015 07:10 PM, Gabe Alford wrote:
>> Thanks. Updated patch attached.
>>
>>
>> Gabe
>>
>> On Fri, Nov 20, 2015 at 10:36 AM, Martin Babinsky <mbabinsk at redhat.com
>> <mailto:mbabinsk at redhat.com>> wrote:
>>
>>     On 11/20/2015 04:02 PM, Gabe Alford wrote:
>>
>>         Hello,
>>
>>         Fix for https://fedorahosted.org/freeipa/ticket/5470
>>
>>         Thanks,
>>
>>         Gabe
>>
>>
>>     Hi Gabe,
>>
>>     patch looks good. IMHO it would be better if you moved the check
>>     before API initialization like so:
>>
>>     """
>>     @@ -340,6 +340,12 @@ class WinsyncMigrate(admintool.AdminTool):
>>               the plumbing.
>>               """
>>
>>     +        # Check if the IPA server is configured before attempting
>>     to migrate
>>     +        try:
>>     +            installutils.check_server_configuration()
>>     +        except RuntimeError as e:
>>     +            sys.exit(e)
>>     +
>>               # Finalize API
>>               api.bootstrap(in_server=True, context='server')
>>               api.finalize()
>>     """
>>
>>     There's no point in initializing API if there is no server installed.
>>
>>     --
>>     Martin^3 Babinsky
>>
>>
> Thanks, ACK.
> 

Pushed to:
master: 84e479edaaeb64567f4cfc847aa735bbd106220d
ipa-4-2: dbc442cc608a49726bcca9749b01dcd363b3ed8f