[Freeipa-devel] [PATCH] 0749 Package ipapython, ipalib, ipaplatform, ipatests for Python 3

[Jan Cholasta]

Hi,

On 6.11.2015 13:07, Petr Viktorin wrote:
> Hello,
> The Python 3 port is not 100% done, but I think the time has come to
> start packaging the py3 bits. This will make it easier to plug into CI.
>
> The existing Python 2 packages should not change, except I've added
> "freeipa-common" with files that aren't Python-specific.
>
> The new packages follow Fedora's Python guidelines a bit better. The
> main thing is the names: python3-ipalib, python3-ipatests,
> python3-ipap11helper.
> The pure-Python ones are built as noarch.
>
>
> The Makefiles are reorganized a bit, but they don't support building for
> both py versions at once -- you need to do `make` followed by `make
> PYTHON=/usr/bin/python3`. (The latter currently only works in the
> directories that are ported so far, though.)

Thanks for the patch.


1) The freeipa-common subpackage is not necessary: /etc/ipa/dnssec 
should be owned by freeipa-server and everything else in /etc/ipa 
currently owned by freeipa-python should be owned by freeipa-client.

This should be a separate patch. I have prepared one, see attachment.


2) IMO this patch does too much, it should only add the Python 3 
equivalent of freeipa-python - python3-ipalib - but none of the other 
packages/provides.


3) Speaking of freeipa-python, it should be renamed to python-ipalib, 
for consistency.

This should also be a separate patch, again see attachment.


4) There should be a python3-devel (and also other python3- equivalents 
of python- packages) BuildRequires when Python 3 support is enabled.


5) This line in ipapython/ipap11helper/Makefile uses a Python 2 print 
statement:

PYTHONLIBDIR ?= $(shell $(PYTHON) -c "from distutils.sysconfig import *; 
print get_python_lib()")


6) The ipalib Makefile is missing the "check" target (see ipapython 
Makefile).


Honza

-- 
Jan Cholasta
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-516-spec-file-remove-non-Python-files-from-freeipa-pytho.patch
Type: text/x-patch
Size: 3600 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151126/9fb4e2ea/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-jcholast-517-spec-file-rename-freeipa-python-to-python-ipalib.patch
Type: text/x-patch
Size: 4710 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151126/9fb4e2ea/attachment-0001.bin>