[Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

[Milan Kubík]

On 11/27/2015 03:36 PM, Milan Kubík wrote:
> On 11/27/2015 03:31 PM, Milan Kubík wrote:
>> On 11/23/2015 10:43 AM, Lenka Doudova wrote:
>>> NACK - there's a "typo" in ..../tracker/user_plugin.py, line 17-18:
>>>
>>> def get_user_dn(cn):
>>>
>>>     return DN(('cn', cn), api.env.container_user, api.env.basedn)
>>>
>>>
>>> should be
>>>
>>> def get_user_dn(uid):
>>>
>>>     return DN(('uid', uid), api.env.container_user, api.env.basedn)
>>>
>>>
>>> Some tests may fail because of that.
>>> Lenka
>>>
>>>
>>> On 11/20/2015 08:54 PM, Aleš Mareček wrote:
>>>> Looks good. ACK.
>>>>
>>>> ----- Original Message -----
>>>>> From: "Milan Kubík" <mkubik at redhat.com>
>>>>> To: "freeipa-devel" <freeipa-devel at redhat.com>
>>>>> Cc: "Filip Skola" <fskola at redhat.com>, "Ales Marecek" 
>>>>> <amarecek at redhat.com>
>>>>> Sent: Friday, November 20, 2015 3:44:30 PM
>>>>> Subject: [patch 0025] Separated Tracker implementations into 
>>>>> standalone package
>>>>>
>>>>> Fixes https://fedorahosted.org/freeipa/ticket/5467
>>>>> Patches attached.
>>>>>
>>>>> -- 
>>>>> Milan Kubik
>>>>>
>>>>>
>>>
>> Fixed the function and moved it into different module.
>> Updated patches attached.
>>
>>
>>
> Self nack, some imports missing
>
> -- 
> Milan Kubik
>
>
Patches updated.

-- 
Milan Kubik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151127/3f9628d4/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-0025-3-Separated-Tracker-implementations-into-standalone-pa.patch
Type: text/x-patch
Size: 112040 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151127/3f9628d4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-ipa42-0025-3-Separated-Tracker-implementations-into-standalone-pa.patch
Type: text/x-patch
Size: 112059 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151127/3f9628d4/attachment-0001.bin>