[Freeipa-devel] [PATCH] Removed duplicate domain name validation function

Stanislav Laznicka slaznick at redhat.com
Fri Nov 27 15:06:41 UTC 2015


Please, see the modified patch attached.

Standa

On 11/27/2015 03:48 PM, Martin Basti wrote:
>
>
> On 27.11.2015 15:33, Petr Spacek wrote:
>> On 27.11.2015 15:32, Martin Basti wrote:
>>>
>>> On 25.11.2015 17:18, Stanislav Laznicka wrote:
>>>> There were two functions for the same purpose. Removed one.
>>>>
>>>>
>>> Hello,
>>>
>>> I would like to have "log" param of is_host_resolvable as optional
>> Is there an immediate need for the optional param? If not, I would 
>> not clutter
>> the code.
>>
> So at least I would like to move log param as the last param, in case 
> of need it can be modified to optional parameter.
>
> Or log can be default as root_logger, IMO we us only root_logger 
> everywhere, but this need investigation.
>
> Martin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-stlaz-0010-Removed-duplicate-domain-name-validating-function.patch
Type: text/x-patch
Size: 9033 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151127/be00d9d3/attachment.bin>


More information about the Freeipa-devel mailing list