[Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package

[Martin Basti]

NACK

1)
With this patch I received this error in test_user_plugin.py

E           AssertionError: assert_deepequal: expected != got.
E             0106: user_status: Query status of "tuser1"
E             expected = 1
E             got = 2
E             path = ('count',)

I have just admin user on my system

2)
______________________________________________________________________________ 
ERROR collecting test_xmlrpc/test_stageuser_plugin.py 
______________________________________________________________________________
test_xmlrpc/test_stageuser_plugin.py:28: in <module>
     from ipatests.test_xmlrpc.tracker.user_plugin import UserTracker
E   ImportError: No module named tracker.user_plugin
______________________________________________________________________________ 
ERROR collecting test_xmlrpc/test_stageuser_plugin.py 
______________________________________________________________________________
test_xmlrpc/test_stageuser_plugin.py:28: in <module>
     from ipatests.test_xmlrpc.tracker.user_plugin import UserTracker
E   ImportError: No module named tracker.user_plugin

3)
________________________________________________________________________________ 
ERROR collecting test_xmlrpc/test_group_plugin.py 
________________________________________________________________________________
test_xmlrpc/test_group_plugin.py:34: in <module>
     from ipatests.test_xmlrpc.tracker.user_plugin import UserTracker
E   ImportError: No module named tracker.user_plugin
________________________________________________________________________________ 
ERROR collecting test_xmlrpc/test_group_plugin.py 
________________________________________________________________________________
test_xmlrpc/test_group_plugin.py:34: in <module>
     from ipatests.test_xmlrpc.tracker.user_plugin import UserTracker
E   ImportError: No module named tracker.user_plugin

4)
________________________________________________________________________________ 
ERROR collecting test_xmlrpc/test_host_plugin.py 
_________________________________________________________________________________
test_xmlrpc/test_host_plugin.py:42: in <module>
     from ipatests.test_xmlrpc.tracker.host_plugin import HostTracker
E   ImportError: No module named tracker.host_plugin
________________________________________________________________________________ 
ERROR collecting test_xmlrpc/test_host_plugin.py 
_________________________________________________________________________________
test_xmlrpc/test_host_plugin.py:42: in <module>
     from ipatests.test_xmlrpc.tracker.host_plugin import HostTracker
E   ImportError: No module named tracker.host_plugin

5)
________________________________________________________________________________ 
ERROR collecting test_xmlrpc/test_caacl_plugin.py 
________________________________________________________________________________
test_xmlrpc/test_caacl_plugin.py:15: in <module>
     from ipatests.test_xmlrpc.test_certprofile_plugin import 
default_profile
../_pytest/assertion/rewrite.py:171: in load_module
     py.builtin.exec_(co, mod.__dict__)
test_xmlrpc/test_certprofile_plugin.py:17: in <module>
     from ipatests.test_xmlrpc.tracker.certprofile_plugin import 
CertprofileTracker
E   ImportError: No module named tracker.certprofile_plugin
________________________________________________________________________________ 
ERROR collecting test_xmlrpc/test_caacl_plugin.py 
________________________________________________________________________________
test_xmlrpc/test_caacl_plugin.py:15: in <module>
     from ipatests.test_xmlrpc.test_certprofile_plugin import 
default_profile
../_pytest/assertion/rewrite.py:171: in load_module
     py.builtin.exec_(co, mod.__dict__)
test_xmlrpc/test_certprofile_plugin.py:17: in <module>
     from ipatests.test_xmlrpc.tracker.certprofile_plugin import 
CertprofileTracker
E   ImportError: No module named tracker.certprofile_plugin


....

N)
rpm -ql freeipa-tests | grep tracker
returns nothing, IMO the tracker directory in not in RPM


On 30.11.2015 17:50, Aleš Mareček wrote:
> Tested with today's master, ACK.
>   - alich -
>
> ----- Original Message -----
>> From: "Milan Kubík" <mkubik at redhat.com>
>> To: freeipa-devel at redhat.com
>> Sent: Friday, November 27, 2015 3:40:29 PM
>> Subject: Re: [Freeipa-devel] [patch 0025] Separated Tracker implementations into standalone package
>>
>> On 11/27/2015 03:36 PM, Milan Kubík wrote:
>>
>>
>>
>> On 11/27/2015 03:31 PM, Milan Kubík wrote:
>>
>>
>> On 11/23/2015 10:43 AM, Lenka Doudova wrote:
>>
>>
>> NACK - there's a "typo" in ..../tracker/user_plugin.py, line 17-18:
>>
>> def get_user_dn(cn):
>>
>> return DN(('cn', cn), api.env.container_user, api.env.basedn)
>>
>>
>> should be
>>
>> def get_user_dn(uid):
>>
>> return DN(('uid', uid), api.env.container_user, api.env.basedn)
>>
>>
>> Some tests may fail because of that.
>> Lenka
>>
>>
>> On 11/20/2015 08:54 PM, Aleš Mareček wrote:
>>
>>
>> Looks good. ACK.
>>
>> ----- Original Message -----
>>
>>
>> From: "Milan Kubík" <mkubik at redhat.com>
>> To: "freeipa-devel" <freeipa-devel at redhat.com>
>> Cc: "Filip Skola" <fskola at redhat.com> , "Ales Marecek" <amarecek at redhat.com>
>> Sent: Friday, November 20, 2015 3:44:30 PM
>> Subject: [patch 0025] Separated Tracker implementations into standalone
>> package
>>
>> Fixes https://fedorahosted.org/freeipa/ticket/5467
>> Patches attached.
>>
>> --
>> Milan Kubik
>>
>>
>>
>> Fixed the function and moved it into different module.
>> Updated patches attached.
>>
>>
>>
>> Self nack, some imports missing
>>
>> --
>> Milan Kubik
>>
>>
>> Patches updated.
>>
>> --
>> Milan Kubik
>>
>> --
>> Manage your subscription for the Freeipa-devel mailing list:
>> https://www.redhat.com/mailman/listinfo/freeipa-devel
>> Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code