[Freeipa-devel] [patch 0020] ipatests: configure Network Manager not to manage resolv.conf

[Milan Kubík]

On 10/01/2015 12:39 PM, Alexander Bokovoy wrote:
> On Thu, 01 Oct 2015, Milan Kubík wrote:
>> On 10/01/2015 11:23 AM, Martin Basti wrote:
>>>
>>>
>>> On 10/01/2015 10:18 AM, Milan Kubík wrote:
>>>> On 10/01/2015 10:06 AM, Milan Kubík wrote:
>>>>> Fixes https://fedorahosted.org/freeipa/ticket/5331
>>>>>
>>>>> Patch attached.
>>>>>
>>>>>
>>>> Patch for ipa-4-2 branch.
>>>>
>>>> Milan
>>>>
>>>>
>>> NACK
>>>
>>> http://fpaste.org/273499/43691381/
>> I disagree. From [1]:
>>
>>    Fedora now by default relies on NetworkManager for network 
>> configuration. This is the case also for minimal installations and 
>> server installations.
>>
>> The cloud image, which you are probably using does not have 
>> NetworkManager installed. I think we can rely on the default here and 
>> assume
>> NetworkManager is present.
>>
>> If you and the list disagree, I will make the fix depend on 
>> NetworkManager's presence.
>> Nitpick: there can be other services that manage (and rewrite) 
>> resolv.conf.
> While other tools may do it, please make it so that your fix only
> activated if NetworkManager is active.
>
> We'll get to other services once we'll encounter them.
>
Ok. Now I only apply the config and restart NetworkManager when it is 
already running. I don't check if the service is enabled.

-- 
Milan Kubik

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ipa42-mkubik-0020-1-ipatests-configure-Network-Manager-not-to-manage-res.patch
Type: text/x-patch
Size: 3320 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151001/c2346cd5/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-0020-1-ipatests-configure-Network-Manager-not-to-manage-res.patch
Type: text/x-patch
Size: 3317 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151001/c2346cd5/attachment-0001.bin>