[Freeipa-devel] [PATCH] Workaround for trac N 5348

[Oleg Fayans]

Hi Jan,

On 10/08/2015 10:44 AM, Jan Pazdziora wrote:
> On Wed, Oct 07, 2015 at 04:13:25PM +0200, Oleg Fayans wrote:
>> subj
>>
>> --
>> Oleg Fayans
>> Quality Engineer
>> FreeIPA team
>> RedHat.
>
>>  From 7ab1afe5e9a8f6b28be2d5b92423eccec61248a0 Mon Sep 17 00:00:00 2001
>> From: Oleg Fayans <ofayans at redhat.com>
>> Date: Wed, 7 Oct 2015 16:08:30 +0200
>> Subject: [PATCH] Added a workaround for ticket N 5348
>>
>> After creating signed root zone, the server requires named.service restart for dig
>> requests to this zone to start displaying the key.
>> ---
>>   ipatests/test_integration/test_dnssec.py | 12 +++++++++---
>>   1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/ipatests/test_integration/test_dnssec.py b/ipatests/test_integration/test_dnssec.py
>> index 098b227f6543fa221ed6c75d1e98e9f056761977..b63c6ce4795c53c5c2dd604783c321835d8a689b 100644
>> --- a/ipatests/test_integration/test_dnssec.py
>> +++ b/ipatests/test_integration/test_dnssec.py
>> @@ -280,7 +280,10 @@ class TestInstallDNSSECFirst(IntegrationTest):
>>               "--ns-rec=" + self.master.hostname
>>           ]
>>           self.master.run_command(args)
>> -
>> +        # A workaround for ticket N 5348
>> +        time.sleep(20)
>> +        self.master.run_command(["systemctl", "restart", "named-pkcs11.service"])
>
> When the ticket is addressed and these workarounds are no longer
> needed -- what is our process for finding these workarounds and
> reverting them, so that the tests test the real, expected behaviour?

As per discussion with Martin Basti, it was decided that this workaround 
will only be applied to the current 4-2 branch, not to the upstream. In 
upstream the issue itself will (supposedly) be solved

>
> Also, instead of blind sleeps, wouldn't it be better to have some
> polling for status of the services we are waiting for?

Since we still do not know what exactly causes the issue, it is really 
hard to figure out what is it that we should be polling. Otherwise I am 
really anti-blind-sleeps myself.

>

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.