[Freeipa-devel] [PATCH 0084] hide topology segment direction in topology command CLI and webui interface

[Oleg Fayans]

Hi Ludwig,

On 10/13/2015 12:55 PM, Ludwig Krispenz wrote:
>
> On 10/13/2015 12:43 PM, Oleg Fayans wrote:
>> Hi guys,
>>
>> On 10/13/2015 12:34 PM, Petr Vobornik wrote:
>>> On 10/13/2015 12:19 PM, Martin Babinsky wrote:
>>>> On 10/13/2015 10:15 AM, Petr Vobornik wrote:
>>>>> On 10/13/2015 10:02 AM, Oleg Fayans wrote:
>>>>>> NACK
>>>>>>
>>>>>> UI still shows the connectivity information at
>>>>>>
>>>>>> http://<hostname>/ipa/ui/#/e/topologysuffix/topologysegment/realm
>>>>>
>>>>> Showing it is correct and desired - both in CLI and Web UI.
>>>>>
>>>>
>>>> So IIUC the segment connectivity should not be asked interactively, but
>>>> when topology-show command is run it should show up in the output?
>>>
>>> That's correct.
>>
>> Still I do not understand what's the point in showing the user
>> parameters which he can not possibly change. Is there a use-case when
>> the connectivity can be anything else than "both"? If not, why should
>> we complicate the output?
> it's the property of a segment. After the segment is created also
> leftnode and rightnode can no longer be changed - would you hide them ?
> during replica install all segments are initially created from an
> agreement as left-right and then merged, the connectivity could indicate
> a failure during install.

Oh, OK, that's a fair point. Thank you for clarification!
Then - yes, let's return this info into the output of 
topologysegment-find and *-show commands

> it is just informational, but it doesn't hurt beingthere
>
>>
>>>
>>>>
>>>>> The end state should be that UIs will create new segments with
>>>>> direction=both and they will not allow to modify it.
>>>>>
>>>>> So the issue, ticket #5222 is IMO about, is that CLI asks for a
>>>>> value in
>>>>> interactive prompt which could be used to change the value from
>>>>> both to
>>>>> some other.
>>>>>
>>>>>>
>>>>>> CLI is OK, though
>>>>>>
>>>>>> On 10/12/2015 05:57 PM, Martin Babinsky wrote:
>>>>>>> https://fedorahosted.org/freeipa/ticket/5222
>>>>>>>
>>>>
>>>>
>>>
>>>
>>
>

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.