[Freeipa-devel] [PATCH 0085] remove idoverrides when deleting a user
Martin Babinsky
mbabinsk at redhat.com
Wed Oct 14 07:02:58 UTC 2015
This patch fixes a regression which was caused by incorrect refactoring
of user-del command in commit c6299a8cfde7d4e4bb9a50e3cf6406667cee0a6f
While the `remove_ipaobject_overrides` function was originally called in
the execute method, this patch puts it into the pre-callback because:
1.) it is called in pre-callback of group-del
2.) by putting it into pre-callback the overrides are removed for each
entry when multiple primary keys are specified (maybe it would be good
to have a test case for this?)
3.) since LDAPDelete does not return any entry attributes (it is a
delete after all), it is not possible to put it into post-callback
without hacking either the function itself or LDAPDelete class
4.) due to this design you have to call it before execution anyway
https://fedorahosted.org/freeipa/ticket/5365
--
Martin^3 Babinsky
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbabinsk-0085-remove-ID-overrides-when-deleting-a-user.patch
Type: text/x-patch
Size: 1044 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151014/9cfd00f7/attachment.bin>
More information about the Freeipa-devel
mailing list