[Freeipa-devel] [PATCH] admintool: Add error message with path to log on failure.

David Kupka dkupka at redhat.com
Thu Oct 15 11:24:13 UTC 2015


On 15/10/15 13:02, Tomas Babej wrote:
>
>
> On 10/15/2015 12:33 PM, David Kupka wrote:
>> Currently, when there is unhanded exception without any message,
>> installer ends with error code but without any error message.
>>
>> Adding line stating that some error occurred and where are logs located
>> should help with debugging.
>>
>>
>>
>
> The default value for the log_file_name is None, so we probably need to
> handle this correctly in case the AdminTool class instance logs to
> stderr only.
>
> Tomas
>

Thanks for good catch, fixed patch attached.
I guess the same is true for command_name but it is used quite 
extensively it the code so it's probably safe to assume that it will be 
always set.

-- 
David Kupka
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-dkupka-0067.1-admintool-Add-error-message-with-path-to-log-on-fail.patch
Type: text/x-patch
Size: 1015 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151015/e1399779/attachment.bin>


More information about the Freeipa-devel mailing list