[Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

[Martin Babinsky]

On 10/19/2015 02:47 PM, Martin Basti wrote:
>
>
> On 15.10.2015 16:29, Martin Babinsky wrote:
>> https://fedorahosted.org/freeipa/ticket/5175
>>
>>
>>
> NACK
>
> with domain level 0
>
> ipa-replica-prepare <replica_hostname>
>
> ipa.ipaserver.install.ipa_replica_prepare.ReplicaPrepare: DEBUG: File
> "/usr/lib/python2.7/site-packages/ipapython/admintool.py", line 169, in
> execute
>      self.ask_for_options()
>    File
> "/usr/lib/python2.7/site-packages/ipaserver/install/ipa_replica_prepare.py",
> line 215, in ask_for_options
>      bind_pw=self.dirman_password)
>    File "/usr/lib/python2.7/site-packages/ipalib/backend.py", line 61,
> in connect
>      self.id, threading.currentThread().getName()
> ipa.ipaserver.install.ipa_replica_prepare.ReplicaPrepare: DEBUG: The
> ipa-replica-prepare command failed, exception: Exception: connect:
> 'context.ldap2_140616703529424' already exists in thread 'MainThread'
> ipa.ipaserver.install.ipa_replica_prepare.ReplicaPrepare: ERROR:
> connect: 'context.ldap2_140616703529424' already exists in thread
> 'MainThread'
> ipa.ipaserver.install.ipa_replica_prepare.ReplicaPrepare: ERROR: The
> ipa-replica-prepare command failed.
>
> without your patch it works
>
> Martin^2

The function was leaking opened backend connection due to incorrect 
disconnect logic. Updated patch should fix this.

-- 
Martin^3 Babinsky
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mbabinsk-0086.2-disable-ipa-replica-prepare-in-non-zero-IPA-domain-l.patch
Type: text/x-patch
Size: 2926 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151019/29134b7d/attachment.bin>