[Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels
Tomas Babej
tbabej at redhat.com
Fri Oct 23 07:25:05 UTC 2015
> One more point:
>
> + if domain_level > MIN_DOMAIN_LEVEL:
> + raise RuntimeError(
> + UNSUPPORTED_DOMAIN_LEVEL_TEMPLATE.format(
>
> It is kind of weird that error happens if domain level is greater than some
> minimal value. Better naming is badly needed.
>
Actually, this is not about naming, MIN_DOMAIN_LEVEL constant should not
be used at all.
The constant can be increased to 2 or 3 in later releases, which will
allow the usage of ipa-replica-prepare even if the domain level of the
IPA domain is 1.
Unlike other issues with this patch, which could be considered cosmetic,
this actually is a real bug in the implementation.
Tomas
More information about the Freeipa-devel
mailing list