[Freeipa-devel] [PATCH 0012-0019] CA ACL tracker and functional test

[Milan Kubík]

On 10/20/2015 02:19 PM, Martin Basti wrote:
>
> NACK
>
>
>
> 1)
>
> I still see many hardcoded passwords in the code
>
> with change_principal(smime_user, "Secret123"):
>
For now changed to module variable.
>
>
> 2)
>
> Also the 'alice' username can be extracted to module variable
> instead hardcoding
>
>
The fixture should take the place of module variables in the tests. 
Changed u'alice' into local variable.
Once we fix the problems with UserTracker, we should store the password 
here as well.
>
> 3)
>
> File alice.conf.tmpl can be generalized to be used for more users,
> replace alice in template to {username} and in code replace this
> variable with alice, also do not forgot rename template to something
> more general
>
>
>
Done.
>
>
>
>
>
>
>

Updated patch set attached.

-- 
Milan Kubik

-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-0012.4-ipatests-add-fuzzy-instances-for-CA-ACL-DN-and-RDN.patch
Type: text/x-patch
Size: 1139 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-0013.4-ipatests-Add-initial-CAACLTracker-implementation.patch
Type: text/x-patch
Size: 15040 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-0014.5-tests-add-test-to-check-the-default-ACL.patch
Type: text/x-patch
Size: 5880 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-0015-3-ipatests-CA-ACL-added-config-templates.patch
Type: text/x-patch
Size: 10502 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-0016-2-ipatests-added-unlock_principal_password-and-change_.patch
Type: text/x-patch
Size: 2484 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-0017-4-ipatests-CA-ACL-and-cert-profile-functional-test.patch
Type: text/x-patch
Size: 16654 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment-0005.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-ipa42-0012.4-ipatests-add-fuzzy-instances-for-CA-ACL-DN-and-RDN.patch
Type: text/x-patch
Size: 1133 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment-0006.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-ipa42-0013.4-ipatests-Add-initial-CAACLTracker-implementation.patch
Type: text/x-patch
Size: 15040 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment-0007.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-ipa42-0014.5-tests-add-test-to-check-the-default-ACL.patch
Type: text/x-patch
Size: 5880 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment-0008.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-ipa42-0015-3-ipatests-CA-ACL-added-config-templates.patch
Type: text/x-patch
Size: 10502 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment-0009.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-ipa42-0016-2-ipatests-added-unlock_principal_password-and-change_.patch
Type: text/x-patch
Size: 2394 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment-0010.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-mkubik-ipa42-0017-4-ipatests-CA-ACL-and-cert-profile-functional-test.patch
Type: text/x-patch
Size: 16654 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151023/aa16b3de/attachment-0011.bin>