[Freeipa-devel] [PATCH] enable pem=True in export_pem_cert function

Niranjan mrniranjan at fedoraproject.org
Wed Oct 28 00:29:19 UTC 2015


Tomas Babej wrote:
> On 10/26/2015 08:59 PM, Niranjan wrote:
> > Greetings,
> > 
> > export_pem_cert function from ipapython/certdb  should export the certificate
> > in pem format but instead exports the cert in der format as it doesn't enable pem=True.
> > 
> > This patch specifies pem=True for export_pem_cert function
> > 
> > Regards
> > Niranjan
> 
> Hi,
> 
> the patch looks good, however, I'm curious as to how did you find this
> bug? Does it affect anything?
I am part of the CS(dogtag) QE team, and as part of CS Automation, i am relying 
on some generic functions provided by ipapython. While using those functions
for our automation, I found it. 
> 
> It seems to me that this part of the code is a dead branch which should
> be removed.
I did not look further ipapython, so i am not aware where else export_pem_cert
is being used, but i would like the functions in certdb.py be available.
> 
> $ git grep export_pem_cert
> ipapython/certdb.py:    def export_pem_cert(self, nickname, location):
> ipaserver/install/certs.py:    def export_pem_cert(self, nickname,
> ipaserver/install/certs.py:        return self.nssdb.export_pem_ce..
> 
> Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 311 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151028/9349cbee/attachment.sig>


More information about the Freeipa-devel mailing list