[Freeipa-devel] [PATCH] DNSZone command with user friendly message

[Abhijeet Kasurde]

On 10/27/2015 08:28 PM, Martin Basti wrote:
>
>
> On 27.10.2015 14:46, Martin Basti wrote:
>>
>>
>> On 27.10.2015 13:00, Abhijeet Kasurde wrote:
>>> Hi All,
>>>
>>> This patch fixes bug - https://fedorahosted.org/freeipa/ticket/4811
>>>
>>> Thanks,
>>> Abhijeet Kasurde
>>>
>>>
>> [Tue Oct 27 14:44:51.328615 2015] [wsgi:error] [pid 5556] ipa: ERROR: 
>> non-public: AttributeError: 'dnszone' object has no attribute 
>> 'handle_obj_found'
>> [Tue Oct 27 14:44:51.328654 2015] [wsgi:error] [pid 5556] Traceback 
>> (most recent call last):
>> [Tue Oct 27 14:44:51.328659 2015] [wsgi:error] [pid 5556]   File 
>> "/usr/lib/python2.7/site-packages/ipaserver/rpcserver.py", line 350, 
>> in wsgi_execute
>> [Tue Oct 27 14:44:51.328664 2015] [wsgi:error] [pid 5556] result = 
>> self.Command[name](*args, **options)
>> [Tue Oct 27 14:44:51.328669 2015] [wsgi:error] [pid 5556]   File 
>> "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 447, in 
>> __call__
>> [Tue Oct 27 14:44:51.328674 2015] [wsgi:error] [pid 5556] ret = 
>> self.run(*args, **options)
>> [Tue Oct 27 14:44:51.328678 2015] [wsgi:error] [pid 5556]   File 
>> "/usr/lib/python2.7/site-packages/ipalib/frontend.py", line 764, in run
>> [Tue Oct 27 14:44:51.328683 2015] [wsgi:error] [pid 5556] return 
>> self.execute(*args, **options)
>> [Tue Oct 27 14:44:51.328687 2015] [wsgi:error] [pid 5556]   File 
>> "/usr/lib/python2.7/site-packages/ipalib/plugins/dns.py", line 2935, 
>> in execute
>> [Tue Oct 27 14:44:51.328692 2015] [wsgi:error] [pid 5556] result = 
>> super(dnszone_enable, self).execute(*keys, **options)
>> [Tue Oct 27 14:44:51.328696 2015] [wsgi:error] [pid 5556]   File 
>> "/usr/lib/python2.7/site-packages/ipalib/plugins/dns.py", line 2262, 
>> in execute
>> [Tue Oct 27 14:44:51.328701 2015] [wsgi:error] [pid 5556] 
>> self.obj.handle_obj_found(*keys)
>> [Tue Oct 27 14:44:51.328705 2015] [wsgi:error] [pid 5556] 
>> AttributeError: 'dnszone' object has no attribute 'handle_obj_found'
>>
>>
>>
> Thank you, ACK patch works as expected
>
> However now 2 tests are failing because error message was changed, 
> please fix tests too.
>
> test_xmlrpc/test_dns_plugin.py <- 
> test_xmlrpc/xmlrpc_test.py::test_forward_zones::test_command[0071: 
> dnsforwardzone_disable: Try to disable non-existent forward zone] FAILED
> test_xmlrpc/test_dns_plugin.py <- 
> test_xmlrpc/xmlrpc_test.py::test_forward_zones::test_command[0075: 
> dnsforwardzone_enable: Try to enable non-existent forward zone] FAILED
>
> E           AssertionError: assert_deepequal: expected != got.
> E
> E             expected = u'no such entry'
> E             got = u'non-existent.fwzone.test.: DNS forward zone not 
> found'
> E             path = ()
>
Updated patch with testcase
> Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151028/69f6f523/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-akasurde-0001-3-Added-user-friendly-error-message-for-dnszone-enable.patch
Type: text/x-patch
Size: 2974 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151028/69f6f523/attachment.bin>