[Freeipa-devel] [PATCH 0020-0021] some topology plugin fixes

[thierry bordaz]

On 10/30/2015 09:57 AM, Ludwig Krispenz wrote:
>
> On 10/29/2015 01:28 PM, thierry bordaz wrote:
>> On 10/23/2015 10:44 AM, Ludwig Krispenz wrote:
>>> Hi,
>>> the attached two patches address issues I found when testing ca 
>>> management in the topology plugin
>>>
>>> Thanks for review,
>>> Ludwig
>>>
>>>
>> Hi Ludwig,
>>
>> Patch 20 is good to me. I have one remark, you call 
>> ipa_topo_cfg_host_find with lock flag. So that the replica config is 
>> not updated during the test.
>> Now the lock protects each call separately. The risk is very low that 
>> the target host could become unmanaged by the time we test the source 
>> host.
> yes, and if two paralle operations do related things like adding an 
> agreement and making a host managed/unmanaged there is a race for the 
> lock. The lock itself cannot prevent these things, it only can protect 
> the data structures from being read while modified.
> Also with two separate locked calls the second call has a chance to be 
> aware of parallel changes
>> ACK.
>>
>> Patch 21 is also good. Just in ipa_topo_util_init_hosts, why not 
>> calling ipa_topo_cfg_host_add to not duplicate the source ?
> no reason, revised patch is attached, thanks for noticing

Thanks Ludwig for the changes.

ACK

>>
>> thanks
>> thierry
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20151030/4b52bd05/attachment.htm>