[Freeipa-devel] [PATCH 0339] ipa-csreplica-manage: disable connect/disconnect/del subcommands

Martin Babinsky mbabinsk at redhat.com
Fri Oct 30 13:49:34 UTC 2015


On 10/30/2015 02:09 PM, Martin Basti wrote:
> https://fedorahosted.org/freeipa/ticket/5405
>
>
> Patch attached
>
>
Hi Martin,

NACK since I'm not a big fan of having (nearly) the same function 
defined in multiple modules:

"""
$ git grep -n 'def exit_on_managed_topology'
install/tools/ipa-csreplica-manage:397:def 
exit_on_managed_topology(what, hint="topologysegment"):
install/tools/ipa-replica-manage:1386:def exit_on_managed_topology(what):
"""

Otherwise the patch works fine.

-- 
Martin^3 Babinsky




More information about the Freeipa-devel mailing list