[Freeipa-devel] [PATCH 0339] ipa-csreplica-manage: disable connect/disconnect/del subcommands

[Martin Babinsky]

On 10/30/2015 03:47 PM, Martin Basti wrote:
>
>
> On 30.10.2015 14:49, Martin Babinsky wrote:
>> On 10/30/2015 02:09 PM, Martin Basti wrote:
>>> https://fedorahosted.org/freeipa/ticket/5405
>>>
>>>
>>> Patch attached
>>>
>>>
>> Hi Martin,
>>
>> NACK since I'm not a big fan of having (nearly) the same function
>> defined in multiple modules:
>>
>> """
>> $ git grep -n 'def exit_on_managed_topology'
>> install/tools/ipa-csreplica-manage:397:def
>> exit_on_managed_topology(what, hint="topologysegment"):
>> install/tools/ipa-replica-manage:1386:def exit_on_managed_topology(what):
>> """
>>
>> Otherwise the patch works fine.
>>
> I tried to do that, but I could not find any suitable module for that,
> and the method do just exit() with proper error message, thus it can be
> just copy paste (as ipa-csreplica-manage is full of it).
Yes it is a nice plate of copypasta anyway.

ACK then.

-- 
Martin^3 Babinsky