[Freeipa-devel] [PATCH] 0041 certprofile: remove 'rename' option
Jan Cholasta
jcholast at redhat.com
Wed Sep 2 06:40:13 UTC 2015
On 2.9.2015 08:37, Fraser Tweedale wrote:
> On Wed, Sep 02, 2015 at 08:08:09AM +0200, Jan Cholasta wrote:
>> Hi,
>>
>> On 2.9.2015 03:16, Fraser Tweedale wrote:
>>> This patch *removes* the --rename option from certprofile-mod.
>>> For context see: https://bugzilla.redhat.com/show_bug.cgi?id=1257163#c6
>>
>> Instead of just removing it, you could also add:
>>
>> DeprecatedParam(
>> 'rename?',
>> label=_("Rename"),
>> doc=_("Rename the Certificate Profile object"),
>> )
>>
>> to certprofile_mod.takes_options to make the option available, but
>> deprecated.
>>
> Petr Viktorin suggested that due to a) certprofile being a new
> command and b) rename having always been refused, it made sense to
> just remove it.
>
> Petr, are you in agreement or is Honza's suggestion the way to go?
FYI I'm fine with just removing the option, this was just a suggestion
in case deprecation was overlooked.
--
Jan Cholasta
More information about the Freeipa-devel
mailing list