[Freeipa-devel] [PATH 0053] Inconsistency between ipasearchrecordslimit and --sizelimit

[Gabe Alford]

Yup. You are right. It was a mistake. Updated patch attached.

On Tue, Sep 15, 2015 at 12:46 AM, Jan Cholasta <jcholast at redhat.com> wrote:

> On 14.9.2015 14:58, Gabe Alford wrote:
>
>> Sounds good to me. Updated patch attached.
>>
>> On Mon, Sep 14, 2015 at 1:34 AM, Petr Spacek <pspacek at redhat.com
>> <mailto:pspacek at redhat.com>> wrote:
>>
>>     On 14.9.2015 07:23, Jan Cholasta wrote:
>>     > IMO it does, because saying just "-1 is default" is not entirely
>> correct and
>>     > "0 is default" would be confusing, as you pointed out. You might
>> say "0 or -1
>>     > is unlimited" if you think it's clearer.
>>
>>     my +1 to "0 or -1 is unlimited" variant
>>
>>     Petr^2 Spacek
>>
>>
>>      > On 10.9.2015 18:39, Gabe Alford wrote:
>>      >> Oops.. replied without the list.
>>      >>
>>      >> Reason I said -1 is because users might be confused if they
>>     enter `ipa
>>      >> config-mod --searchtimelimit=0`, and both `ipa user-show` and
>>     the webui
>>      >> show -1 instead of 0. I wonder if -1 makes more sense in that
>>     regard?
>>      >> Thoughts? Does "<= 0 is unlimited" make more sense?
>>      >>
>>      >> Thanks,
>>      >>
>>      >> Gabe
>>
>>
> The doc for ipasearchtimelimit and ipasearchrecordslimit says "-1 is
> unlimited", but both 0 and -1 is unlimited for them, and the doc for
> timelimit and sizelimit says "-1 or 0 is unlimited", but only 0 is
> unlimited for them. Looks like a mistake.
>
> --
> Jan Cholasta
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150915/6efcb43f/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-rga-0053-8-Standardize-minvalue-for-ipasearchrecordlimit-and-ip.patch
Type: text/x-patch
Size: 8577 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150915/6efcb43f/attachment.bin>