[Freeipa-devel] [PATCH] improved logging in dnssec tests

Oleg Fayans ofayans at redhat.com
Tue Sep 22 09:21:33 UTC 2015


Hi all,

I've noticed that in some tests some low-level functions can return 
False in a number of different conditions, which severely complicates 
test debugging.
This patch implements the approach widely used in the Go language (and 
maybe, some other): The function returns not only a boolean, but a 
boolean plus any error message caught during the execution. This error 
message may be used by the higher level code for logging. For example, 
compare these outputs:
1. AssertionError: Zone example.test. is not signed (master): request 
timed out
2. AssertionError: Zone example.test. is not signed (master)

What do you think?

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ofayans-0008-Added-error-propagation-for-imroved-debugging.patch
Type: text/x-patch
Size: 22087 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150922/ca14c415/attachment.bin>


More information about the Freeipa-devel mailing list