[Freeipa-devel] [PATCHES 362-366] Realmdomains handling improvements

[Martin Basti]

On 09/22/2015 02:23 PM, Tomas Babej wrote:
> On 09/03/2015 04:34 PM, Alexander Bokovoy wrote:
>> On Thu, 03 Sep 2015, Tomas Babej wrote:
>>> Hi,
>>>
>>> this couple of patches fix https://fedorahosted.org/freeipa/ticket/5278
>>> and improve our handling of realmdomains in general.
>> The code looks good to me. I haven't tested it yet, though.
>>
> Rebased on top of current master.

Please fix tests too.

[root at vm-065 ~]# ipa-run-tests test_xmlrpc/test_realmdomains_plugin.py 
--verbose
=============================================================================================== 
test session starts 
===============================================================================================
platform linux2 -- Python 2.7.10 -- py-1.4.30 -- pytest-2.6.4 -- 
/usr/bin/python
plugins: multihost, sourceorder
collected 13 items

test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0000: 
realmdomains_show: Retrieve realm domains] PASSED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0001: 
realmdomains_show: Retrieve realm domains - print all attributes] PASSED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0002: 
realmdomains_mod: Replace list of realm domains with 
"[u'abc.idm.lab.eng.brq.redhat.com', u'example1.com']"] FAILED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0003: 
realmdomains_mod: Add domain "example2.com" to list] FAILED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0004: 
realmdomains_mod: Delete domain "example2.com" from list] FAILED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0005: 
realmdomains_mod: Add domain "example2.com" and delete domain 
"example1.com"] FAILED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0006: 
realmdomains_mod: Try to specify --domain and --add-domain options 
together] FAILED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0007: 
realmdomains_mod: Try to replace list of realm domains with a list 
without our domain] FAILED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0008: 
realmdomains_mod: Try to replace list of realm domains with a list with 
an invalid domain "doesnotexist.test"] FAILED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0009: 
realmdomains_mod: Try to add an invalid domain "doesnotexist.test"] FAILED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0010: 
realmdomains_mod: Try to delete our domain] FAILED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0011: 
realmdomains_mod: Try to delete domain which is not in list] PASSED
test_xmlrpc/test_realmdomains_plugin.py <- 
test_xmlrpc/xmlrpc_test.py::test_realmdomains::test_command[0012: 
realmdomains_mod: Add an invalid domain "doesnotexist.test" with --force 
option] FAILED