[Freeipa-devel] [PATCH] 0087 Fix an integer underflow bug in libotp

[Tomas Babej]

On 09/29/2015 03:10 PM, Tomas Babej wrote:
> 
> 
> On 09/29/2015 01:57 PM, Tomas Babej wrote:
>>
>> On 09/25/2015 06:38 PM, Nathaniel McCallum wrote:
>>> On Fri, 2015-09-25 at 12:18 -0400, Nathaniel McCallum wrote:
>>>> Temporarily storing the offset time in an unsigned integer causes the
>>>> value of the offset to underflow when a (valid) negative offset value
>>>> is generated. Using a signed variable avoids this problem.
>>>
>>> This new version makes the patch smaller.
>>>
>>>
>>>
>>
>> ACK, this fixes the issue, I was able to synchronize with negative
>> offset after applying the patch.
> 
> Pushed to:
> master: d3cca6db57fb26aea1d45bc522336dddc6256825
> ipa-4-2: 3c52f62e6c4e07b107780d95a6a4ff79d89c75b9
> 
> Issue filed under: https://fedorahosted.org/freeipa/ticket/5333
> 

Well, actually, correct hashes are:

Pushed to:
master: 9e3eeadeb3120f3577e00ab9cb410eccf8d71de0
ipa-4-2: 7db0a8e8512733ff91462b9b3b20c21ad6ec4212