[Freeipa-devel] [PATCH] Proper fix for ticket 5306

[Oleg Fayans]

On 09/30/2015 11:46 AM, Petr Spacek wrote:
> On 29.9.2015 09:12, Oleg Fayans wrote:
>> +def prepare_reverse_zone(host, ip):
>> +    zone = get_reverse_zone_default(ip)
>> +    host.run_command(["ipa",
>> +                      "dnszone-add",
>> +                      zone,
>> +                      "--name-from-ip=%s" % ip], raiseonerr=False)
>
> There is probably no point in specifying --name-from-ip because you did that
> already by calling get_reverse_zone_default(ip).

Agree. Fixed

>
> Anyway, I'm not sure that this
>> +    prepare_reverse_zone(master, replica.ip)
> will not break if the reverse zone already exists (think about case where two
> or more replicas are in the same subnet).

That's why I am using the raiseonerr=False here.

>
> I did not test the code, I simply do not have time for it right now.
>

-- 
Oleg Fayans
Quality Engineer
FreeIPA team
RedHat.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeipa-ofayans-0007.2-Added-a-proper-workaround-for-dnssec-test-failures.patch
Type: text/x-patch
Size: 2840 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/freeipa-devel/attachments/20150930/be885e5d/attachment.bin>